[TH2-5132] behaviour.permittedToRemoveNamespace option #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Nikita-Smirnov-Exactpro
commented
Nov 27, 2023
Nikita-Smirnov-Exactpro
commented
- added logging and secret value check
* added logging and secret value check
OptimumCode
reviewed
Nov 27, 2023
src/main/java/com/exactpro/th2/inframgr/repository/RepositoryWatcherService.java
Outdated
Show resolved
Hide resolved
OptimumCode
approved these changes
Nov 28, 2023
OptimumCode
approved these changes
Nov 29, 2023
src/main/java/com/exactpro/th2/inframgr/repository/RepositoryWatcherService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/inframgr/NamespaceController.java
Outdated
Show resolved
Hide resolved
| @@ -113,7 +114,7 @@ public Set<String> deleteSecrets(String schemaName, Set<String> secretEntries) { | |||
| } | |||
| secret.setData(data); | |||
| try { | |||
| kubernetesClient.resource(secret).inNamespace(namespace).createOrReplace(); | |||
| kubernetesClient.resource(secret).inNamespace(namespace).serverSideApply(); | |||
There was a problem hiding this comment.
Why have you started using serverSideApply instead createOrReplace? Is there any particular reason for that?
There was a problem hiding this comment.
createOrReplace is deprecated, auto-replacing recommends serverSideApply
OptimumCode
reviewed
Nov 30, 2023
| @@ -72,30 +73,31 @@ private void startInformers() { | |||
| } | |||
|
|
|||
| logger.info("Creating informers"); | |||
| Kubernetes kube = new Kubernetes(config.getBehaviour(), config.getKubernetes(), null); | |||
| cache = K8sResourceCache.INSTANCE; | |||
| try (Kubernetes kube = new Kubernetes(config.getBehaviour(), config.getKubernetes(), null)) { | |||
There was a problem hiding this comment.
Honestly, it looks like this class should have the kubernetes instance as a field
OptimumCode
approved these changes
Dec 1, 2023
src/main/java/com/exactpro/th2/inframgr/DescriptorController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/inframgr/k8s/KubernetesController.java
Outdated
Show resolved
Hide resolved
OptimumCode
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.