fixes for RM-84612 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 27, 2024 11:29
…portMessageStoreSender / ProtobufMessageStoreSender init) 'raw' attribute removed from transport pins
…portMessageStoreSender / ProtobufMessageStoreSender init) 'raw' attribute removed from transport pins
Nikita-Smirnov-Exactpro
requested changes
Apr 1, 2024
build.gradle
Outdated
| implementation('com.exactpro.remotehand:remotehand:1.7.3-TH2-4662-4046816762-SNAPSHOT') { | ||
| exclude group: "org.slf4j", module: "slf4j-log4j12" | ||
| } | ||
| implementation('com.exactpro.remotehand:remotehand:1.7.3-TH2-4662-no-log4j-8506347590-SNAPSHOT') |
There was a problem hiding this comment.
Migrate to release version before merge
Comment on lines
38
to
39
| public TransportMessageStoreSender(Config config) { | ||
| messageRouter = config.getFactory().getTransportGroupBatchRouter(); |
There was a problem hiding this comment.
Could we rename Config to Context because getting factory from config looks strange?
Test Results3 tests 3 ✅ 0s ⏱️ Results for commit 830d5fd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.