Rm 84612 - implement support of th2 transport #52
Conversation
* updated github workflow
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
src/main/java/com/exactpro/th2/hand/builders/events/EventPayloadBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/hand/builders/mstore/ProtobufMessageStoreBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/hand/services/mstore/MessageStoreHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/hand/services/mstore/ProtobufMessageStoreSender.java
Outdated
Show resolved
Hide resolved
…from the same process without network
| } | ||
|
|
||
| tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach { | ||
| kotlinOptions.jvmTarget = "11" |
There was a problem hiding this comment.
This part can be replaced with the following code as top-level declaration
kotlin {
jvmToolchain(11)
}
|
|
||
| import java.nio.file.Path; | ||
| import java.util.Map; | ||
|
|
||
| public interface MessageStoreBuilder<T> { | ||
| ObjectMapper MAPPER = new ObjectMapper(); |
There was a problem hiding this comment.
Do we serialize/deserialize any kotlin classes using this mapper? If we do it is better to register a Kotlin module here as well
There was a problem hiding this comment.
I don't think so
| private static <E extends Throwable> void sneakyThrow(Throwable e) throws E { | ||
| //noinspection unchecked | ||
| throw (E) e; | ||
| } |
There was a problem hiding this comment.
And why would we use this hack in java? How will anybody know that this method might throw a checked exception?
Even Kotlin provides annotations to help Java understand if a checked exception might be thrown by the method. But we use this hack to hide this information. Why don't we just wrap the exception in runtime exception in this case?
There was a problem hiding this comment.
I think you are right because gRPC StatusRuntimeException isn't handled in act-win-core
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit af0bdfa. |
No description provided.