Skip to content

Commit

Permalink
after review
Browse files Browse the repository at this point in the history
  • Loading branch information
Oleg Smelov committed Jun 12, 2024
1 parent a9624c2 commit 6c2c1b5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
9 changes: 1 addition & 8 deletions perftest/perftest.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,6 @@ spec:
-XX:MaxDirectMemorySize=50M
-Ddatastax-java-driver.advanced.connection.init-query-timeout="5000 milliseconds"
-Ddatastax-java-driver.basic.request.timeout="3 seconds"
-Dcom.sun.management.jmxremote
-Dcom.sun.management.jmxremote.port=1099
-Dcom.sun.management.jmxremote.rmi.port=1099
-Dcom.sun.management.jmxremote.ssl=false
-Dcom.sun.management.jmxremote.authenticate=false
-Dcom.sun.management.jmxremote.local.only=false
-Djava.rmi.server.hostname=127.0.0.1
resources:
limits:
cpu: 2500m
Expand Down Expand Up @@ -124,7 +117,7 @@ spec:
| RAM | 433 MB | 1.93 GB | 3.8 GB |
## Computation resources th2-estore metrics
![th2-estore resources](estore_res.png)
![th2-estore resources](estore_res.png)\
![th2-estore heap usage](estore_heap.png)
## Computation resources RabbitMQ metrics
Expand Down
11 changes: 10 additions & 1 deletion src/main/java/com/exactpro/th2/estore/ProtoUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
import com.exactpro.th2.common.grpc.MessageIDOrBuilder;
import com.exactpro.th2.common.util.StorageUtils;
import com.google.common.base.Strings;
import com.google.protobuf.InvalidProtocolBufferException;
import com.google.protobuf.Timestamp;
import com.google.protobuf.util.JsonFormat;

import java.util.Collection;
import java.util.Comparator;
Expand All @@ -48,7 +50,14 @@ public static StoredMessageId toStoredMessageId(MessageIDOrBuilder messageId) {
public static StoredTestEventId toCradleEventID(EventIDOrBuilder protoEventID) {
String id = protoEventID.getId();
if (Strings.isNullOrEmpty(id)) {
throw new IllegalArgumentException("No unique identifier specified for event: " + protoEventID);
String eventString;
try {
eventString = JsonFormat.printer().print(protoEventID);
} catch (InvalidProtocolBufferException e) {
eventString = protoEventID.toString();
}

throw new IllegalArgumentException("No unique identifier specified for event: " + eventString);
}

return new StoredTestEventId(
Expand Down

0 comments on commit 6c2c1b5

Please sign in to comment.