[TS-1163] Initial version #1
Conversation
cordwelt
force-pushed
the
ts-1163
branch
7 times, most recently
from
3a249b2 to
6fa9296
Compare
| @@ -0,0 +1,23 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
could you please discuss @Xanclry about using common workflow from .github repository
https://github.com/th2-net/.github/pull/7/files
There was a problem hiding this comment.
@Xanclry could you please help? Because I don't really understand what should be done here. Should I add some of the workflows from the PR above?
| api platform('com.exactpro.th2:bom:3.2.0') | ||
|
|
||
| implementation 'com.exactpro.th2:conn-dirty-tcp-core:2.0.0' | ||
| implementation 'com.exactpro.th2:common:3.40.0-TH2-3789-2817159492-SNAPSHOT' |
There was a problem hiding this comment.
Could we use release version instead
There was a problem hiding this comment.
This is a dev build with session-group support. Did we release session-groups?
src/main/kotlin/com/exactpro/th2/codec/soup/bin/tcp/SoupBinTcpHandler.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/codec/soup/bin/tcp/SoupBinTcpHandler.kt
Outdated
Show resolved
Hide resolved
|
|
||
| while (channel.isOpen && !isLoggedIn) { | ||
| logger.warn { "Waiting for login to send a message" } | ||
| Thread.sleep(1000) |
There was a problem hiding this comment.
Please replace to ReenteredLock.Condition technology instead of sleeping constant time
There was a problem hiding this comment.
Does it really worth it here? Especially considering that messages are rarely sent by a user
src/main/kotlin/com/exactpro/th2/codec/soup/bin/tcp/SoupBinTcpHandler.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/codec/soup/bin/tcp/SoupBinTcpHandler.kt
Show resolved
Hide resolved
| logger.debug { "Sending client heartbeat - session: $session" } | ||
| writeShort(EMPTY_MESSAGE_LENGTH) | ||
| writeByte(CLIENT_HEARTBEAT_TYPE) | ||
| channel.send(this).get() |
There was a problem hiding this comment.
Should we wait operation complete in this case?
No description provided.