Add ability to limit outgoing message rate #142
Conversation
| import java.util.concurrent.TimeUnit.SECONDS | ||
| import java.util.concurrent.locks.LockSupport | ||
|
|
||
| class RateLimiter(rate: Int) { |
There was a problem hiding this comment.
This implementation isn't thread-safe, and we should remind about this if we want to use more than one thread for AMQP
There was a problem hiding this comment.
I can make it thread-safe
| @@ -94,7 +95,7 @@ public void stop() throws IOException { | |||
| private void handle(String consumerTag, RawMessageBatch messageBatch) { | |||
| for (RawMessage protoMessage : messageBatch.getMessagesList()) { | |||
| try { | |||
| rateLimiter.acquire(); | |||
| while (!rateLimiter.tryAcquire()) LockSupport.parkNanos(1_000); | |||
There was a problem hiding this comment.
Let's encapsulate the cycle in the tryAcquire function
cordwelt
force-pushed
the
rate-limiter
branch
from
9f748c6 to
3c78b1f
Compare
Co-authored-by: Nikita Smirnov <[email protected]>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
gradle.properties
Outdated
| @@ -1 +1,5 @@ | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Resolve conflicts
Nikita-Smirnov-Exactpro
changed the base branch from
dev-version-3-tmp
to
dev
No description provided.