-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Th2 3717 #139
base: dev-version-3
Are you sure you want to change the base?
Th2 3717 #139
Conversation
* updated Readme * changed dummy implementation of MessageRouter on Mock * changed dummy eventDispatcher on Mock * changed dummy implementation of MessageRouter on Mock * changed dummy eventDispatcher on Mock * minor fixes Co-authored-by: Oleg Smirnov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like everything is okay but let's not merge it into dev yet.
Also, please resolve merge conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Please, add this version of the conn to the issue and build a test images for th2-conn-generic
No description provided.