Avoid double logon

th2-net · Nov 18, 2024 · 96b72f6 · 96b72f6
1 parent 730cce2
commit 96b72f6
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/src/main/java/com/exactpro/th2/FixHandler.java b/src/main/java/com/exactpro/th2/FixHandler.java
@@ -1200,8 +1200,6 @@ private void sendHeartbeatWithTestRequest(String testRequestId, boolean possDup)
                 communicationLock.unlock();
             }
 
-        } else {
-            sendLogon();
         }
     }
 
@@ -1229,8 +1227,6 @@ public void sendTestRequestWithPossDup(boolean isPossDup) { //do private
             } finally {
                 communicationLock.unlock();
             }
-        } else {
-            sendLogon();
         }
         reconnectRequestTimer = executorService.schedule(this::sendLogon, settings.getReconnectDelay(), TimeUnit.SECONDS);
     }
@@ -1247,8 +1243,6 @@ public void sendLogon() {
             return;
         }
 
-        activeLogonExchange.set(true);
-
         if(enabled.get()) {
             String message = String.format("Logon attempt while already logged in: %s - %s", channel.getSessionGroup(), channel.getSessionAlias());
             LOGGER.warn(message);
@@ -1258,12 +1252,15 @@ public void sendLogon() {
 
         StringBuilder logon = buildLogon(props);
 
-        LOGGER.info("Send logon - {}", logon);
-        channel.send(Unpooled.wrappedBuffer(logon.toString().getBytes(StandardCharsets.UTF_8)),
-                        strategy.getState().enrichProperties(props),
-                        null,
-                        SendMode.HANDLE_AND_MANGLE)
-            .thenAcceptAsync(x -> strategy.getState().addMessageID(x), executorService);
+        if(!activeLogonExchange.get()) {
+            activeLogonExchange.set(true);
+            LOGGER.info("Send logon - {}", logon);
+            channel.send(Unpooled.wrappedBuffer(logon.toString().getBytes(StandardCharsets.UTF_8)),
+                            strategy.getState().enrichProperties(props),
+                            null,
+                            SendMode.HANDLE_AND_MANGLE)
+                    .thenAcceptAsync(x -> strategy.getState().addMessageID(x), executorService);
+        }
     }
 
     private StringBuilder buildLogon(Map<String, String> props) {