Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publishing confirmation to redeliver messages that were not confi… #306

Merged
merged 16 commits into from
Jun 6, 2024

Conversation

OptimumCode
Copy link
Member

…rmed by broker.

The implementation does not handle cases when message in the middle was not confirmed. Unfortunately, there is not much we can do here

Copy link

github-actions bot commented May 26, 2024

Test Results

 31 files  ±0   31 suites  ±0   5s ⏱️ ±0s
391 tests ±0  391 ✅ ±0  0 💤 ±0  0 ❌ ±0 
445 runs  ±0  445 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 84a094b. ± Comparison against base commit 7ea3bd4.

This pull request removes 88 and adds 45 tests. Note that renamed tests count towards both.
        nanos: 471855000
        nanos: 472144000
        nanos: 472217000
        nanos: 472295000
        nanos: 507988000
        nanos: 508033000
        nanos: 521631000
        nanos: 521717000
        nanos: 528764000
        nanos: 528876000
…
com.exactpro.th2.common.schema.filter.strategy.impl.TestAnyMessageFilterStrategy ‑ [1] message {
  metadata {
    id {
      connection_id {
        session_alias: "test-alias"
      }
      book_name: "test_book"
      timestamp {
        seconds: 1717582933
        nanos: 264725000
      }
    }
    message_type: "test"
    properties {
      key: "prop-field1"
      value: "prop-value1"
    }
    properties {
      key: "prop-field2"
      value: "prop-value2"
    }
  }
}
, true
com.exactpro.th2.common.schema.filter.strategy.impl.TestAnyMessageFilterStrategy ‑ [1] message {
  metadata {
    id {
      connection_id {
        session_alias: "test-alias"
      }
      book_name: "test_book"
      timestamp {
        seconds: 1717582933
        nanos: 317589000
      }
    }
    message_type: "test"
    protocol: "HTTP"
  }
}
, true
com.exactpro.th2.common.schema.filter.strategy.impl.TestAnyMessageFilterStrategy ‑ [1] message {
  metadata {
    id {
      connection_id {
        session_alias: "test-alias"
      }
      book_name: "test_book"
      timestamp {
        seconds: 1717582933
        nanos: 325845000
      }
    }
    message_type: "test"
  }
  fields {
    key: "test-field1"
    value {
      simple_value: "test-value1"
    }
  }
  fields {
    key: "test-field2"
    value {
      simple_value: "test-value2"
    }
  }
}
, true
com.exactpro.th2.common.schema.filter.strategy.impl.TestAnyMessageFilterStrategy ‑ [1] message {
  metadata {
    id {
      connection_id {
        session_alias: "test-alias"
      }
      book_name: "test_book"
      timestamp {
        seconds: 1717582933
        nanos: 337814000
      }
    }
    message_type: "test"
  }
}
, true
com.exactpro.th2.common.schema.filter.strategy.impl.TestAnyMessageFilterStrategy ‑ [1] message {
  metadata {
    id {
      connection_id {
        session_alias: "test-alias"
      }
      book_name: "test_book"
      timestamp {
        seconds: 1717582933
        nanos: 349485000
      }
    }
    message_type: "test"
    properties {
      key: "test-property"
      value: "property-value"
    }
  }
}
, true
com.exactpro.th2.common.schema.filter.strategy.impl.TestAnyMessageFilterStrategy ‑ [1] message {
  metadata {
    id {
      connection_id {
        session_alias: "test-alias"
      }
      book_name: "test_book"
      timestamp {
        seconds: 1717582933
        nanos: 358516000
      }
    }
    message_type: "test"
  }
  fields {
    key: "test-field"
    value {
      simple_value: "test-value1"
    }
  }
}
, true
com.exactpro.th2.common.schema.filter.strategy.impl.TestAnyMessageFilterStrategy ‑ [1] message {
  metadata {
    id {
      connection_id {
        session_alias: "test-alias"
      }
      book_name: "test_book"
      timestamp {
        seconds: 1717582933
        nanos: 364548000
      }
    }
    message_type: "test"
  }
  fields {
    key: "test-field"
    value {
      simple_value: "test-value2"
    }
  }
}
, true
com.exactpro.th2.common.schema.filter.strategy.impl.TestAnyMessageFilterStrategy ‑ [1] message {
  metadata {
    id {
      connection_id {
        session_alias: "test-alias"
      }
      book_name: "test_book"
      timestamp {
        seconds: 1717582933
        nanos: 368228000
      }
    }
    message_type: "test"
  }
  fields {
    key: "test-field1"
    value {
      simple_value: "test-value1"
    }
  }
  fields {
    key: "test-field2"
    value {
      simple_value: "test-value2"
    }
  }
}
, true
com.exactpro.th2.common.schema.filter.strategy.impl.TestAnyMessageFilterStrategy ‑ [1] message {
  metadata {
    id {
      connection_id {
        session_alias: "test-alias"
      }
      book_name: "test_book"
      timestamp {
        seconds: 1717582933
        nanos: 387273000
      }
    }
    message_type: "test"
  }
}
, true
com.exactpro.th2.common.schema.filter.strategy.impl.TestAnyMessageFilterStrategy ‑ [1] message {
  metadata {
    id {
      connection_id {
        session_alias: "test-alias"
      }
      book_name: "test_book"
      timestamp {
        seconds: 1717582933
        nanos: 392625000
      }
    }
    message_type: "test"
  }
  fields {
    key: "test-field"
    value {
      simple_value: "test-value1"
    }
  }
}
, false
…

♻️ This comment has been updated with latest results.

@OptimumCode OptimumCode marked this pull request as ready for review May 28, 2024 14:05
@OptimumCode
Copy link
Member Author

@Nikita-Smirnov-Exactpro @lumber1000 could you please take a look at the changes?

@OptimumCode OptimumCode merged commit 236125c into master Jun 6, 2024
13 checks passed
@OptimumCode OptimumCode deleted the th2-5200 branch June 6, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants