Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rise th2_component metric with box name as name label value #295

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

Nikita-Smirnov-Exactpro
Copy link
Member

No description provided.

Copy link

Test Results

 30 files   30 suites   4s ⏱️
380 tests 380 ✅ 0 💤 0 ❌
434 runs  434 ✅ 0 💤 0 ❌

Results for commit 01eebbb.

@OptimumCode
Copy link
Member

Are you sure that you based this PR on the right branch? I see comments that are not related to this PR

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro changed the base branch from master to mq-connection-name April 16, 2024 07:39
@Nikita-Smirnov-Exactpro
Copy link
Member Author

Are you sure that you based this PR on the right branch? I see comments that are not related to this PR

Corrected, thank you

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro changed the base branch from mq-connection-name to master April 16, 2024 07:46
@OptimumCode
Copy link
Member

Corrected, thank you

What is corrected? There are still commits that do not belong to this change. I think the only way to fix this is to rebase this branch based on the current master state (and drop all the duplicated commits)

Copy link
Member

@OptimumCode OptimumCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want you can merge it as is. But I think that we need to fix commit history first

@Nikita-Smirnov-Exactpro
Copy link
Member Author

If you want you can merge it as is. But I think that we need to fix commit history first

I'm going to use squash and merge

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro merged commit 3b76270 into master Apr 16, 2024
1 check passed
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro deleted the th2_component_metric branch April 16, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants