[Th2 5107] User can't change gRPC retry configuration via schema #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the whole default gRPC retry interval is about 1 hour
OptimumCode
reviewed
Oct 25, 2023
src/test/kotlin/com/exactpro/th2/common/schema/grpc/router/impl/DefaultGrpcRouterTest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/common/schema/grpc/configuration/GrpcRetryConfiguration.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| clientServerBaton.get("wait client thread start") | ||
| Thread.sleep(RETRY_TIMEOUT * 2) |
There was a problem hiding this comment.
Why do we need to wait here? If you need to make sure the task is executed within a timeout you can use Assertions.assertTimeoutPreemptively method
There was a problem hiding this comment.
I use fixed retry timeout in these tests. I wait time to grantee that client switch to retry mode. The time can be reduced because gRPC router begin retry after first failure
src/test/kotlin/com/exactpro/th2/common/schema/grpc/router/impl/DefaultGrpcRouterTest.kt
Outdated
Show resolved
Hide resolved
OptimumCode
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.