TH2-4267 split common #232
Conversation
| @@ -38,6 +38,7 @@ ext { | |||
|
|
|||
| repositories { | |||
| mavenCentral() | |||
| mavenLocal() | |||
There was a problem hiding this comment.
Should be the last repo in the list
There was a problem hiding this comment.
I don't agree. I think it will be first or won't be because if you build project via clean build pTML gradle publishes artifact as release.
If we want to write mavenLocal() in the build.gradle script it should be first otherwise we shouldn't be specified
src/main/kotlin/com/exactpro/th2/common/module/provider/FileConfigurationProviderFactory.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/common/schema/configuration/ConfigurationManager.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/common/module/FileConfigurationProviderFactoryShim.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/common/schema/factory/CommonFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/common/schema/factory/CommonFactory.java
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/common/module/provider/FileConfigurationProviderFactory.kt
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/common/module/provider/FileConfigurationProviderFactory.kt
Show resolved
Hide resolved
| ServiceLoader.load(ModuleFactory::class.java).forEach { moduleFactory -> | ||
| modulesFactoryMapping[moduleFactory.moduleType] = moduleFactory | ||
| } |
There was a problem hiding this comment.
Why modules are in the configuration manager? Shouldn't they be in the factory?
There was a problem hiding this comment.
This class has already cached configurations, so I think it's better to put all caching in one place
There was a problem hiding this comment.
Maybe move this cache into an abstract part of ConfigurationProvider CommonFactory to avoid new entities
There was a problem hiding this comment.
After discussion with @Xanclry we have decided to rename ConfigurationManager to ModuleManager
|
|
||
| + Dynamic structure of common | ||
| + Extracted common/cassandra to separate module | ||
| + Implemented api for dynamic loading of modules and configurations |
There was a problem hiding this comment.
| + Implemented api for dynamic loading of modules and configurations | |
| + Implemented the API for dynamic loading of modules and configurations |
There was a problem hiding this comment.
Also we should describe module API and how it works in a real project
src/main/java/com/exactpro/th2/common/schema/factory/AbstractCommonFactory.java
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/common/schema/factory/AbstractCommonFactory.java
Show resolved
Hide resolved
| @Parameter(names = ["-c", "--configs"]) | ||
| lateinit var config: String | ||
|
|
||
| @Parameter(names = ["--rabbitConfiguration"]) | ||
| lateinit var rabbitConfiguration: String | ||
|
|
||
| @Parameter(names = ["--messageRouterConfiguration"]) | ||
| lateinit var messageRouterConfiguration: String | ||
|
|
||
| @Parameter(names = ["--grpcRouterConfiguration"]) | ||
| lateinit var grpcRouterConfiguration: String | ||
|
|
||
| @Parameter(names = ["--grpcConfiguration"]) | ||
| lateinit var grpcConfiguration: String | ||
|
|
||
| @Parameter(names = ["--grpcRouterConfig"]) | ||
| lateinit var grpcRouterConfig: String | ||
|
|
||
| @Parameter(names = ["--customConfiguration"]) | ||
| lateinit var customConfiguration: String | ||
|
|
||
| @Parameter(names = ["--dictionariesDir"]) | ||
| lateinit var dictionariesDir: String | ||
|
|
||
| @Parameter(names = ["--prometheusConfiguration"]) | ||
| lateinit var prometheusConfiguration: String | ||
|
|
||
| @Parameter(names = ["--boxConfiguration"]) | ||
| lateinit var boxConfiguration: String |
There was a problem hiding this comment.
Remove these properties, please use hard coded names for them
src/main/kotlin/com/exactpro/th2/common/module/provider/FileConfigurationProvider.kt
Show resolved
Hide resolved
| ServiceLoader.load(ModuleFactory::class.java).forEach { moduleFactory -> | ||
| modulesFactoryMapping[moduleFactory.moduleType] = moduleFactory | ||
| } |
There was a problem hiding this comment.
Maybe move this cache into an abstract part of ConfigurationProvider CommonFactory to avoid new entities
src/test/kotlin/com/exactpro/th2/common/schema/TestModuleConfiguration.kt
Show resolved
Hide resolved
No description provided.