-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Th2 3202 #189
base: version-3
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that there are any benefits from having a method that returns a path to the archived file. At least we should provide the interface for unzipping it
src/main/java/com/exactpro/th2/common/schema/factory/AbstractCommonFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/common/schema/factory/CommonFactory.java
Outdated
Show resolved
Hide resolved
I should highlight it once again because I honestly don't understand the reason why we can simply return the path to a file that is a ZIPed file. We either should perform unzipping by the common lib or somehow provide user with a simple way to unzip this file somewhere @Nikita-Smirnov-Exactpro @ivandruzhinin @Topru333 what do you think about that? |
@Nikita-Smirnov-Exactpro @ivandruzhinin @Topru333 what do you think about that? @OptimumOpium I agree with your commen. Maybe unzip all dictionaries and save them in special directory at the first call related to dictionary access |
Slightly unrelated question - why do we even serve zipped files to common? I know that we zip files due k8s limitations, but I don't see any reason to not unzip them when a box is deployed (but this probably would be breaking change though) |
Kubernetes provide ability mount resources from configmap, image responsible for additional actions as I understand. |
Then we should probably unzip dictionaries on demand and serve their path or content when required |
No description provided.