Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RM-84612] embedded hand, updated workflow #5

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Conversation

lumber1000
Copy link
Member

embedded hand, updated workflow

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

.github/workflows/ci-unwelcome-words.yml Outdated Show resolved Hide resolved
.github/workflows/ci-unwelcome-words.yml Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated
Comment on lines 46 to 48
implementation "com.exactpro.th2:hand:5.0.0-RM-84612-no-log4j-8506423826-21dd3f8-SNAPSHOT"
implementation "com.exactpro.th2:act-gui-core:3.0.0-RM-84612-8479410336-ceca9b5-SNAPSHOT"
implementation "com.exactpro.th2:grpc-act-uiframework-win-demo:1.3.0-RM-84612-8383647500-b699975-SNAPSHOT"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please migrate to release versions before merge

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to revert this file because the previous version should be compatible to the future versions

Comment on lines 63 to 64
resources.add(actServer::stop);
resources.add(actServer::blockUntilShutdown);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please combine to one coll back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants