Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPRECATED] Feature: Adds integration of topik/youtube-music-obs-widget as plugin #1120

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

topik
Copy link

@topik topik commented Apr 19, 2023

Hello,

I got a request to add a plugin for my obs widget so here it is.

Plugin makes a simple http server and give a info about current song in JSON. The JSON structure is the same as in other YT music software that is being used so the obs widget is compatible.

Feel free to rename the plugin.

Thanks

@Araxeus
Copy link
Collaborator

Araxeus commented Apr 25, 2023

This looks extremely similar to https://github.com/th-ch/youtube-music/blob/master/plugins/tuna-obs/back.js

Could you give a quick explanation why a new plugin is needed?

@topik
Copy link
Author

topik commented Apr 25, 2023

I took some inspiration from tuna-obs because I'm not a Node.js developer. Tuna-obs sends requests to the OBS plugin itself, which means you have to install the OBS (and the OBS plugin) for the whole thing to work.

However, my plugin works the opposite way. It creates a webserver and serves JSON data about the current song, so you don't need to install anything. Just open the plugin's webpage and it will work. You can add the webpage as a source to OBS.

Additionally, my plugin has a different design.

Copy link
Contributor

@ArjixWasTaken ArjixWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: You should use a formatter on your code :^)

plugins/obs-widget/back.js Outdated Show resolved Hide resolved
plugins/obs-widget/back.js Outdated Show resolved Hide resolved
@topik
Copy link
Author

topik commented Jul 21, 2023

PS: You should use a formatter on your code :^)

You are absolutely right, no idea why i didn't do that. I would do it in any other language :| ... Also thanks for pointing out wrong variable type.

@JellyBrick JellyBrick added enhancement New feature or request need rebase This plugin need rebase labels Oct 7, 2023
@JellyBrick JellyBrick changed the title Feature: Adds integration of topik/youtube-music-obs-widget as plugin [DEPRECATED] Feature: Adds integration of topik/youtube-music-obs-widget as plugin Dec 27, 2023
@JellyBrick
Copy link
Collaborator

@topik
Could you rework this PR? The entire plugin system has been reworked.

@JellyBrick JellyBrick marked this pull request as draft November 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request need rebase This plugin need rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants