feature: Try and resolve java home if it's a symlink

Resolves scalameta/metals-vscode#1094
tgodzik · Aug 8, 2022 · 29478bd · 29478bd
1 parent 35aa218
commit 29478bd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/__tests__/getJavaHome.test.ts b/src/__tests__/getJavaHome.test.ts
@@ -20,6 +20,12 @@ describe("getJavaHome", () => {
     expect(javaHome).toBe(javaHomeConfig);
   });
 
+  it("infers-from-symlink", async () => {
+    const javaHomeConfig = "/usr/bin/java";
+    const javaHome = await getJavaHome(javaHomeConfig);
+    expect(javaHome).not.toBe(javaHomeConfig);
+  });
+
   it("reads from JAVA_HOME", async () => {
     const JAVA_HOME = "/path/to/java";
     process.env = { ...originalEnv, JAVA_HOME };

diff --git a/src/getJavaHome.ts b/src/getJavaHome.ts
@@ -39,6 +39,14 @@ function fromConfig(
     typeof configuredJavaHome === "string" &&
     configuredJavaHome.trim() !== ""
   ) {
+    if (fs.existsSync(configuredJavaHome)) {
+      const stat = fs.lstatSync(configuredJavaHome);
+      const realpath = fs.realpathSync(configuredJavaHome);     
+      if (stat.isSymbolicLink() && realpath.endsWith(`bin${path.sep}java`)) {
+        const javaHome = path.dirname(path.dirname(realpath));
+        return TE.right(javaHome);
+      }
+    }
     return TE.right(configuredJavaHome);
   } else {
     return TE.left({});