Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(script-compiler): add id property in lint and fix messages #73

Merged
merged 1 commit into from
Jun 18, 2023
Merged

feat(script-compiler): add id property in lint and fix messages #73

merged 1 commit into from
Jun 18, 2023

Conversation

otariidae
Copy link
Contributor

ref: #72

  • add optional id in lint/fix messages at script-compiler
    • if command message has id, response message always have same id
    • if command message does not have id, response message has id property but it is just undefined
    • mandating id is out of scope for this PR
  • add id where Textlint worker is used, using crypto.randomUUID()

@azu azu added the Type: Feature New Feature label Jun 18, 2023
azu
azu approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@azu azu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azu azu merged commit ff58657 into textlint:master Jun 18, 2023
@azu
Copy link
Member

azu commented Jun 18, 2023

Release https://github.com/textlint/editor/releases/tag/v0.14.0

@otariidae otariidae deleted the add-id-in-msg branch June 18, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azu azu azu approved these changes

Assignees
No one assigned
Labels
Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otariidae @azu