Merge pull request #4 from testiumjs/updates

chore: upgrade packages & deprecate node 8 and below

.eslintignore

@@ -0,0 +1,3 @@
+tmp
+node_modules/
+.git

.eslintrc.json

@@ -0,0 +1,11 @@
+{
+  "extends": "groupon",
+  "overrides": [
+    {
+      "files": "*.test.js",
+      "env": {
+        "mocha": true
+      }
+    }
+  ]
+}

.gitignore

@@ -1,3 +1,4 @@
+.nyc_output
 node_modules/
 /tmp
 npm-debug.log

.travis.yml

@@ -1,16 +1,11 @@
 language: node_js
 node_js:
-  - '0.10'
-  - '4'
-before_install:
-  - npm install -g npm@latest-2
-before_deploy:
-  - 'git config --global user.email "[email protected]"'
-  - 'git config --global user.name "Groupon"'
+  - 10
+  - 12
 deploy:
-  provider: script
-  script: ./node_modules/.bin/nlm release
-  skip_cleanup: true
-  'on':
-    branch: master
-    node: '4'
+  - provider: script
+    script: npx nlm release
+    skip_cleanup: true
+    'on':
+      branch: master
+      node: 12

lib/testium-cookie.js

@@ -29,35 +29,35 @@
  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+
 'use strict';
 
-var _ = require('lodash');
-var debug = require('debug')('testium-cookie');
+const debug = require('debug')('testium-cookie');
 
-function encode(string) {
-  return new Buffer(string).toString('base64');
+function encode(value) {
+  return Buffer.from(value).toString('base64');
 }
 
 function decode(value) {
-  return new Buffer(value, 'base64').toString('utf8');
+  return Buffer.from(value, 'base64').toString('utf8');
 }
 
 function encodeMetaData(headers, statusCode) {
-  var jsonData = JSON.stringify({
-    headers: headers,
-    statusCode: statusCode,
+  const jsonData = JSON.stringify({
+    headers,
+    statusCode,
   });
-  var encodedData = encode(jsonData);
-  return encodedData;
+
+  return encode(jsonData);
 }
 exports.encodeMetaData = encodeMetaData;
 
 function buildCookie(headers, statusCode) {
-  return '_testium_=' + encodeMetaData(headers, statusCode) + '; path=/';
+  return `_testium_=${encodeMetaData(headers, statusCode)}; path=/`;
 }
 
 function modifyResponse(response) {
-  var headers = response.headers = response.headers || {};
+  const headers = (response.headers = response.headers || {});
 
   // This relies on the fact that the existing headers are all lower-cased
   headers['Set-Cookie'] = buildCookie(headers, response.statusCode);
@@ -84,24 +84,30 @@ function tryParse(jsonString) {
     return JSON.parse(jsonString);
   } catch (error) {
     error.message = [
-      'Unable to parse JSON: ' + error.message,
-      'Attempted to parse: ' + jsonString,
+      `Unable to parse JSON: ${error.message}`,
+      `Attempted to parse: ${jsonString}`,
     ].join('\n');
     throw error;
   }
 }
 
 function parseTestiumCookie(cookie) {
-  var json = decode(typeof cookie === 'string' ? cookie : cookie.value);
+  const json = decode(typeof cookie === 'string' ? cookie : cookie.value);
   return tryParse(json);
 }
 
 function getTestiumCookie(cookies) {
   // Gracefully handles the result of cookie.parse and an array of cookie objects
-  var testiumCookie = cookies._testium_ || _.find(cookies, { name: '_testium_' });
+  const testiumCookie =
+    // eslint-disable-next-line no-underscore-dangle
+    cookies._testium_ ||
+    (Array.isArray(cookies) &&
+      cookies.find(({ name }) => name === '_testium_'));
 
   if (!testiumCookie) {
-    throw new Error('Unable to communicate with internal proxy. Make sure you are using relative paths.');
+    throw new Error(
+      'Unable to communicate with internal proxy. Make sure you are using relative paths.'
+    );
   }
 
   return parseTestiumCookie(testiumCookie);