-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow usages of innerHTML for no-container rule #889
base: main
Are you sure you want to change the base?
Disallow usages of innerHTML for no-container rule #889
Conversation
// messageId: 'noContainer', | ||
// }, | ||
// ], | ||
// }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Belco90 This comment-out test is the test that is failing now, that shows us that we are not yet handling the view.container.innerHTML
case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I need to go again through the utils for navigating the nodes, I think we had something to fix the problem described in the main description.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
- Coverage 96.23% 96.21% -0.03%
==========================================
Files 44 44
Lines 2419 2432 +13
Branches 1000 1007 +7
==========================================
+ Hits 2328 2340 +12
- Misses 91 92 +1 ☔ View full report in Codecov by Sentry. |
@CodingItWrong Are you still interested in implementing this feature? If so, can you please rebase onto latest |
Checks
Changes
container
propretyview
, and then it is accessed asview.container.innerHTML
. For container methods, this seems to be caught by the code on lines 95-106. But we can't use that code as-is inMemberExpression()
because of the errorProperty 'callee' does not exist on type 'MemberExpression'.
. Looking over our code, do you have an ideas on how we could detect theview.container.innerHTML
case inMemberExpression()
? @Belco90Context
Fixes #883