Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional headers #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arashnd
Copy link

@arashnd arashnd commented Dec 3, 2024

Thanks for incredible gem!!

In our app we want the ability to pass additional headers (We have custom ActiveStorage::Service class inherits from ActiveStorage::Service::AzureBlobService)

There are many use cases where want to send additional headers for example Customer Provided Keys for Encryption

Azure/azure-storage-ruby#221
https://learn.microsoft.com/en-us/azure/storage/blobs/encryption-customer-provided-keys
https://learn.microsoft.com/en-us/rest/api/storageservices/put-blob

Change is fairly simple but I can improve this PR further if necessary.

@JoeDupuis
Copy link
Member

This is a good idea. We need to add this for the other endpoints with headers too.
There is a couple more writer methods + the reader methods.
I also want to add some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants