ci: add macos & windows runners for testing #1102
clippy
4 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 4 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.82.0-nightly (2cbbe8b8b 2024-07-28)
- cargo 1.82.0-nightly (b5d44db1d 2024-07-26)
- clippy 0.1.82 (2cbbe8b 2024-07-28)
Annotations
Check warning on line 47 in testcontainers/src/core/logs/consumer/logging_consumer.rs
github-actions / clippy
this manual char comparison can be written more succinctly
warning: this manual char comparison can be written more succinctly
--> testcontainers/src/core/logs/consumer/logging_consumer.rs:47:48
|
47 | let message = message.trim_end_matches(|c| c == '\n' || c == '\r');
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['\n', '\r']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
= note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default
Check warning on line 73 in testcontainers/src/core/image/image_ext.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> testcontainers/src/core/image/image_ext.rs:73:9
|
73 | /// If not specified, the daemon default is used, which can either be `\"private\"` or `\"host\"`, depending on daemon version, kerne...
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
73 | /// If not specified, the daemon default is used, which can either be `\"private\"` or `\"host\"`, depending on daemon version, kernel support and configuration.
| ++
Check warning on line 29 in testimages/build.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> testimages/build.rs:27:14
|
27 | .arg(&format!(
| ______________^
28 | | "{cwd}/src/dockerfiles/simple_web_server.dockerfile"
29 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
27 ~ .arg(format!(
28 + "{cwd}/src/dockerfiles/simple_web_server.dockerfile"
29 ~ ))
|
Check warning on line 12 in testimages/build.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> testimages/build.rs:12:14
|
12 | .arg(&format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default