-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow configuring resource ulimits #714
Conversation
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
62c2a1f
to
f8f8c82
Compare
Yeah, unfortunately this requirement comes from But So, as workaround I may suggest using patch of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! 🙏
I've left only one comment, please take a look. Overall looks like LGTM
Thank you for the review! No rush at all, but I'm curious when you can imagine a release including it. |
I think within couple of days since it’s compatible change. |
## 🤖 New release * `testcontainers`: 0.21.0 -> 0.21.1 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.21.1] - 2024-08-05 ### Details #### Features - Allow configuring resource ulimits ([#714](#714)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
It's been released! |
I appreciate the heads up thank you! |
Thanks again for working on this project!
This exposes a way to configure resource ulimits (the
--ulimit
flag fordocker run
).I'm relying on CI tests because I'm currently on Windows and didn't configure my environment to reflect #711, since it seems I'd need to install nasm now, as I received some errors regarding it.