Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove WithResourceMapping(string, string, UnixFileModes) obsolete flag #964

Merged

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

The pull request removes the obsolete flag from the WithResourceMapping(string, string, UnixFileModes) member.

Why is it important?

The behavior of the member has changed. Now, the target (2nd) argument should be a target directory instead of a file path. If the source is a file, the implementation will automatically append the filename to the target directory path.

Related issues

-

@HofmeisterAn HofmeisterAn added the breaking change Causing compatibility issues label Aug 2, 2023
@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit b0fe5a2
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64ca92133e0a450008927aaa
😎 Deploy Preview https://deploy-preview-964--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn merged commit 8344f6a into develop Aug 4, 2023
12 checks passed
@HofmeisterAn HofmeisterAn deleted the feature/remove-obsolete-flag-withresourcemapping branch August 4, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Causing compatibility issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant