Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MySql): Rename default database to test (do not use MySQL system schema) #949

Merged
merged 2 commits into from Jul 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2023

What does this PR do?

Makes sure that the default name of a MySql Database does not conflict with database system schemas

Why is it important?

Its important so you no longer have to call .WithDatabase("test").

Related issues

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 33823f1
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64b7f19e66c7c90008c6a233
😎 Deploy Preview https://deploy-preview-949--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn changed the title [Bug]: Change DefaultDatabase name for MySql #948 fix(MySql): Rename default database to test (do not use MySQL system schema) Jul 20, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Great first contribution 🙏.

@HofmeisterAn HofmeisterAn merged commit 762feda into testcontainers:develop Jul 20, 2023
9 checks passed
@HofmeisterAn HofmeisterAn added the bug Something isn't working label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MySql DefaultDatabase conflicts with system schema
2 participants