Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Milvus module #1131

Merged
merged 3 commits into from
Feb 29, 2024
Merged

feat: Add Milvus module #1131

merged 3 commits into from
Feb 29, 2024

Conversation

roji
Copy link
Contributor

@roji roji commented Feb 28, 2024

This adds a test container for the Milvus vector database.

This largely follows the existing Milvus Java testcontainer; potentially more configuration knobs could be exposed, but we can do that if/when users request them.

Let me know about any adjustments you'd like made!

/cc @yhmo @weianweigan

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 016d61a
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/65e0e23ca1545a00087926f5
😎 Deploy Preview https://deploy-preview-1131--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The module configurations look good 👍. Do you mind if I update some parts to align the module with all the others? Usually, this helps me to refactor stuff that involves changes in the modules too. Either way, I am happy to merge the PR afterwards.

src/Testcontainers.Milvus/Testcontainers.Milvus.csproj Outdated Show resolved Hide resolved
src/Testcontainers.Milvus/MilvusBuilder.cs Outdated Show resolved Hide resolved
@HofmeisterAn HofmeisterAn changed the title Add Milvus test container feat: Add Milvus module Feb 29, 2024
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Feb 29, 2024
@HofmeisterAn HofmeisterAn merged commit 8aed123 into testcontainers:develop Feb 29, 2024
11 checks passed
@roji roji deleted the Milvus branch February 29, 2024 20:51
@roji
Copy link
Contributor Author

roji commented Feb 29, 2024

Thanks for merging @HofmeisterAn! Looking forward to seeing this on nuget.org!

@roji
Copy link
Contributor Author

roji commented Mar 9, 2024

@HofmeisterAn let me know if I can give a hand in updating the docs, or any other task needed to getting this published/doc'ed etc.

@HofmeisterAn
Copy link
Collaborator

The module is published together with a new Testcontainers version/release. If you like, I can create a pull request and add the .NET implementation to the modules catalog after the release.

@roji
Copy link
Contributor Author

roji commented Mar 10, 2024

That would be great, thanks!

russcam added a commit to russcam/testcontainers-dotnet that referenced this pull request Apr 6, 2024
The qdrant gRPC client uses .NET Framework build
of Grpc.Net.Client, which uses WinHttpHandler. The
wiring up is easier on net462 if net462 is targeted
specifically. Same reason why the Milvus container
also targets net462 (testcontainers#1131 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants