fix: Prevent a NullReferenceException when pulling uncached base images to build an image
#1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
changed the title
NullReferenceException when pulling uncached base images to build an image
…ng to create an image
HofmeisterAn
approved these changes
Feb 24, 2024
|
Any chance to get a release or at least a beta with this fix? |
|
I would like to include the builder logging API in the next release as well. I can publish a pre-release as soon as the pull request is merged. I am waiting for some feedback. |
|
Here you are. Sorry for the delay; I wanted to ship the logging API changes in the beta version too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a possible null reference exception when the
RepoTagsproperty of theImagesListResponseis null.Why is it important?
Repeated crashes in tests when the docker instance in not empty makes it unusable
Related issues
How to test this PR
Unfortunately I could not find a public reproducible way, only with some company internal images.
However the fix is minimal and self explaining, just adding a null check.