fix: Use default registry credentials when they are set #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschroeder-zendesk
force-pushed
the
main
branch
from
c4a5e4b
to
791e561
Compare
|
Not sure what needs to be done, but this issue is still causing major issues for my team. We have to manually apply this change to kitchen-dokken locally and then again every time we update ruby versions. It's a pretty simple change. Let me know what else I need to do. |
tschroeder-zendesk
changed the title
tschroeder-zendesk
force-pushed
the
main
branch
from
791e561
to
d1b7581
Compare
|
@test-kitchen/maintainers Can I get some movement here please? |
ramereth
approved these changes
Oct 23, 2024
Stromweld
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows credentials for the default index to be used. In our case we have the business version of docker hub and get a 407 proxy error when we don't use user/pass via PAT token to auth to docker. As such we store the creds and this fix allows that situation to work.
Issues Resolved
List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant
Type of Change
Our release process assumes you are using Conventional Commit messages.
The most important prefixes you should have in mind are:
_fix_: which represents bug fixes, and correlates to a SemVer patch._feat_: which represents a new feature, and correlates to a SemVer minor._feat!_:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.If you have not included a conventional commit message this can be fixed on merge.
Check List