Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove tessdata directory and replace it by a submodule #2459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stweil
Copy link
Contributor

@stweil stweil commented May 23, 2019

Signed-off-by: Stefan Weil [email protected]

@stweil
Copy link
Contributor Author

stweil commented May 23, 2019

This is for further discussion.

The tessdata subdirectory is now filled with data from https://github.com/tesseract-ocr/tessconfigs which is included as a submodule, so for people who just clone the tesseract repository it is empty. Therefore tessdata is no longer included in the build process as a subdirectory, and make install currently does not install tessdata files. There is a new Makefile target: make install-tessdata will install that or fail if the submodule was not cloned.

@stweil
Copy link
Contributor Author

stweil commented May 23, 2019

The problems with AppVeyor look unrelated to my modifications.

@amitdo
Copy link
Collaborator

amitdo commented May 23, 2019

Why? I don't see the benefit here.
IMO, It's just complicating the setup for the poor user.

@zdenop
Copy link
Contributor

zdenop commented May 24, 2019

@amitdo: poor user do not use git ;-) IMO this it start of "rethinking" what is the best way of tesseract distribution. From tessdata only pdf.ttf is really needed (maybe it could be compiled into library???).
Personally I would prefer splitting this project (repository) to more individual parts, that could be consolidated into one repository (for poor users ;-) ). There are at least 3 parts that could exists separately:

  • libtesseract
  • tesseract executable
  • tesseract training tools

@amitdo
Copy link
Collaborator

amitdo commented May 1, 2021

@stweil, if you still want to do it, go ahead. Otherwise, maybe it's time to close this PR.

@amitdo
Copy link
Collaborator

amitdo commented Oct 31, 2021

@stweil,

#2459 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants