Skip to content

Commit

Permalink
Remove unused ifdef.
Browse files Browse the repository at this point in the history
  • Loading branch information
egorpugin committed Mar 31, 2021
1 parent 7227676 commit 4fa05b9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 24 deletions.
21 changes: 0 additions & 21 deletions src/ccstruct/imagedata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ ImageData::ImageData(bool vertical, Pix *pix) : page_number_(0), vertical_text_(
SetPix(pix);
}
ImageData::~ImageData() {
#ifdef TESSERACT_IMAGEDATA_AS_PIX
pixDestroy(&internal_pix_);
#endif
}

// Builds and returns an ImageData from the basic data. Note that imagedata,
Expand Down Expand Up @@ -180,28 +177,12 @@ bool ImageData::SkipDeSerialize(TFile *fp) {
// In case of missing PNG support in Leptonica use PNM format,
// which requires more memory.
void ImageData::SetPix(Pix *pix) {
#ifdef TESSERACT_IMAGEDATA_AS_PIX
internal_pix_ = pix;
#else
SetPixInternal(pix, &image_data_);
#endif
}

// Returns the Pix image for *this. Must be pixDestroyed after use.
Pix *ImageData::GetPix() const {
#ifdef TESSERACT_IMAGEDATA_AS_PIX
# ifdef GRAPHICS_DISABLED
/* The only caller of this is the scaling functions to prescale the
* source. Thus we can just return a new pointer to the same data. */
return pixClone(internal_pix_);
# else
/* pixCopy always does an actual copy, so the caller can modify the
* changed data. */
return pixCopy(NULL, internal_pix_);
# endif
#else
return GetPixInternal(image_data_);
#endif
}

// Gets anything and everything with a non-nullptr pointer, prescaled to a
Expand Down Expand Up @@ -322,7 +303,6 @@ void ImageData::AddBoxes(const std::vector<TBOX> &boxes, const std::vector<std::
}
}

#ifndef TESSERACT_IMAGEDATA_AS_PIX
// Saves the given Pix as a PNG-encoded string and destroys it.
// In case of missing PNG support in Leptonica use PNM format,
// which requires more memory.
Expand Down Expand Up @@ -351,7 +331,6 @@ Pix *ImageData::GetPixInternal(const std::vector<char> &image_data) {
}
return pix;
}
#endif

// Parses the text string as a box file and adds any discovered boxes that
// match the page number. Returns false on error.
Expand Down
3 changes: 0 additions & 3 deletions src/ccstruct/imagedata.h
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,6 @@ class TESS_API ImageData {
private:
std::string imagefilename_; // File to read image from.
int32_t page_number_; // Page number if multi-page tif or -1.
#ifdef TESSERACT_IMAGEDATA_AS_PIX
Pix *internal_pix_;
#endif
std::vector<char> image_data_; // PNG/PNM file data.
std::string language_; // Language code for image.
std::string transcription_; // UTF-8 ground truth of image.
Expand Down

3 comments on commit 4fa05b9

@amitdo
Copy link
Collaborator

@amitdo amitdo commented on 4fa05b9 Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used by Artifex. See #2965.

@zdenop
Copy link
Contributor

@zdenop zdenop commented on 4fa05b9 Apr 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amitdo for looking at context. This PR should be reverted.

@egorpugin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was in 1628a9a

Please sign in to comment.