Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 503 and retry #108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix 503 and retry #108

wants to merge 2 commits into from

Commits on Mar 18, 2024

  1. Fix retransmission logic, 503 error 

    Fixes the dispatcher retransmission logic so that the dispatcher
remembers if one of its attempts might have succeeded (even if it never
received a response from the vehicle).

Categorizes an HTTP 503 code as a possible success, since the server may
return this status code if it relays a command to a vehicle but does not
hear back.
    @sethterashima
    sethterashima authored and Seth Terashima committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5d213ad View commit details
    Browse the repository at this point in the history

  2. Fix open/close/actuate trunk code and documentation 

    The OpenTrunk method was implemented as an alias for ActuateTrunk, but
the commands have different meanings in vehicles with powered trunks and
vehicles without. The implementations are now correct, and the proxied
`actuate_trunk` invokes ActuateTrunk, leaving its behavior unchanged.
    @sethterashima
    sethterashima authored and Seth Terashima committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    30f7b57 View commit details
    Browse the repository at this point in the history