Cluster freshness should fail if no single partition succeeds #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyates
force-pushed
the
51-fail-freshness-if-all-partitions-fail
branch
from
b23e264
to
fb7cc52
Compare
rohanag12
approved these changes
Jun 28, 2022
| @@ -281,7 +283,37 @@ private ListenableFuture<String> measureCluster(Burrow.ClusterClient client) { | |||
| // if all the consumer measurements succeed, then we return the cluster name | |||
There was a problem hiding this comment.
if all the consumer measurements succeed -> if at least one consumer measurement succeeds?
danielfritsch
approved these changes
Jun 28, 2022
Across all the partitions for all topics for all consumers for a given cluster, if we succeed at reading the freshness for at least one of the consumers then the cluster freshness succeeds. Without this, if none the consumers could be evaluated successfully then the cluster would still be marked successful, but that often indicated an incorrectly configured cluster. However, if we are able to read even a single partition, then we can reach the cluster. Maybe its a transient so we should be allowed a next round to try to get more successes. Addresses teslamotors#51
jyates
force-pushed
the
51-fail-freshness-if-all-partitions-fail
branch
from
fb7cc52
to
70afff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Across all the partitions for all topics for all consumers for a given
cluster, if we succeed at reading the freshness for at least one of
the consumers then the cluster freshness succeeds. Without this, if
none the consumers could be evaluated successfully then the cluster
would still be marked successful, but that often indicated an
incorrectly configured cluster. However, if we are able to read even
a single partition, then we can reach the cluster. Maybe its a transient
so we should be allowed a next round to try to get more successes.
Addresses #51