Fix PRs from forks failing CI due to lack of Github secrets #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #527 |
SamZhang02
changed the title
|
I can't really test this lmao but I'll make a dummy PR from a fork after this gets merged to check if it works well |
|
@terror feel free to merge this once you swapped the secret |
|
wait i dont think this is right checks arent running (? |
|
ehhhhhhhhhhhh need more research before proceeding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
=======================================
Coverage 88.11% 88.11%
=======================================
Files 44 44
Lines 6294 6294
=======================================
Hits 5546 5546
Misses 748 748 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be merged after @terror changes the OAuth secret to the dev one.
This has some security implications, because it means the CI will be ran on our resources. Github action codes from forks should be verified to ensure no malicious code before running any actions.