Improve alert styling #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
=======================================
Coverage 87.03% 87.03%
=======================================
Files 41 41
Lines 4128 4128
=======================================
Hits 3593 3593
Misses 535 535 |
Closed
|
yooo no way CI passed |
terror
reviewed
Jul 17, 2023
Comment on lines
+25
to
+32
| error: <IoWarning className='text-red-400 dark:opacity-80' size={25} />, | ||
| success: ( | ||
| <AiFillCheckCircle className='text-green-400 dark:opacity-80' size={23} /> | ||
| ), | ||
| info: ( | ||
| <AiFillInfoCircle className='text-blue-300 dark:opacity-80' size={23} /> | ||
| ), | ||
| warning: <IoWarning className='text-yellow-400 dark:opacity-80' size={25} />, |
There was a problem hiding this comment.
I think we should have a different icon for error and warning. I suggest keeping the icon for warning but change the error icon to VscError
|
We should use this instead |
|
Closing in favour of #416 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve alert styling