-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend refactor #296
Merged
Merged
Frontend refactor #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 43 43
Lines 4065 4065
=======================================
Hits 3530 3530
Misses 535 535 |
terror
force-pushed
the
frontend-refactor
branch
from
June 21, 2023 03:08
a990d02
to
4af7752
Compare
terror
reviewed
Jul 4, 2023
terror
reviewed
Jul 4, 2023
Co-authored-by: liam <[email protected]>
Co-authored-by: liam <[email protected]>
Co-authored-by: liam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General changes
classNames
util withtwMerge
File specific
Alert.tsx
AlertProp
toAlertProps
Autocomplete.tsx
filtered
condition to make it a bit cleanerBoxToggle.tsx
isOpen
prop toopen
CourseCard.tsx
className
for stylesCourseInfo.tsx
CourseRequirements.tsx
ReqsBlock
ReqsBlock
ternary expressionCourseSearchBar.tsx
ExploreFilter.tsx
MultiSelect
instead for the inputCourseTerm
for'Fall' | 'Winter' | 'Summer'
JumpToTopButton.tsx
toggleVisible
MultiSelect.tsx
NavItem.tsx
sm
and largerReviewFilter.tsx
FieldLabel
componentSchedulesDisplay.tsx
SideNav.tsx
Tooltip.tsx
About.tsx
Title
component{' '}
)CoursePage.tsx
Loading
component insteadExplore.tsx
filterIsToggled
tofilterOpen
Instructor.tsx
Loading
component insteadProfile.tsx
py-
classLoading.tsx
utils.ts