Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(gs-interceptor): extract typename in WFS Transaction insert queries correctly #950

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Nov 18, 2024

Description

This PR fixes the determination of the endpoint for WFS-T insert requests where the feature type is given in the element name of the children of <Insert>. Actually, only the first feature type will be returned.

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 375 files.

Valid Invalid Ignored Fixed
312 1 62 0
Click to see the invalid file list
  • shogun-gs-interceptor/src/test/java/de/terrestris/shogun/interceptor/servlet/MutableHttpServletRequestTest.java
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

@@ -0,0 +1,154 @@
package de.terrestris.shogun.interceptor.servlet;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package de.terrestris.shogun.interceptor.servlet;
/*
*
*/
package de.terrestris.shogun.interceptor.servlet;

Copy link
Member

@LukasLohoff LukasLohoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header. Otherwise looks good!

@ahennr ahennr merged commit 616c044 into main Nov 18, 2024
4 checks passed
@ahennr ahennr deleted the gs-interceptor-wfs-transaction-insert branch November 18, 2024 12:29
Copy link
Contributor

🎉 This PR is included in version 21.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants