Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces "mapInteractions" config #942

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

KaiVolland
Copy link
Member

Description

This introduces the mapInteractions config to the DefaultApplicationClientConfig. It allows to configure which interactions should be added to the ol map of the gis-client.

Corresponding handling needs to be added to the shogun-gis-client to actually make this work.

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@KaiVolland KaiVolland merged commit 9fff90d into main Nov 5, 2024
4 checks passed
@KaiVolland KaiVolland deleted the map-interactions-config branch November 5, 2024 14:38
Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KaiVolland, really like that idea!

Generally I would favour to have the appropriate client functionality available at the same time since it might confuse users if the configuration (which would be available in the admin immediately) while it won't effect the clients. Is there a linked PR in the shogun-util available right now? If not, I would suggest to wait to merge this one until it's available.

@@ -0,0 +1,37 @@
/* SHOGun, https://terrestris.github.io/shogun/
*
* Copyright © 2020-present terrestris GmbH & Co. KG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright © 2020-present terrestris GmbH & Co. KG
* Copyright © 2024-present terrestris GmbH & Co. KG

@dnlkoch
Copy link
Member

dnlkoch commented Nov 5, 2024

Oh, too late ;-)

@KaiVolland
Copy link
Member Author

Ooops. I'll add the functionality in the client tomorrow. Shouldn't be to hard.

@dnlkoch
Copy link
Member

dnlkoch commented Nov 6, 2024

No worries, as long as this isn't released, it shouldn't be a problem.

Copy link
Contributor

🎉 This PR is included in version 21.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants