-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces "mapInteractions" config #942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KaiVolland, really like that idea!
Generally I would favour to have the appropriate client functionality available at the same time since it might confuse users if the configuration (which would be available in the admin immediately) while it won't effect the clients. Is there a linked PR in the shogun-util available right now? If not, I would suggest to wait to merge this one until it's available.
@@ -0,0 +1,37 @@ | |||
/* SHOGun, https://terrestris.github.io/shogun/ | |||
* | |||
* Copyright © 2020-present terrestris GmbH & Co. KG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Copyright © 2020-present terrestris GmbH & Co. KG | |
* Copyright © 2024-present terrestris GmbH & Co. KG |
Oh, too late ;-) |
Ooops. I'll add the functionality in the client tomorrow. Shouldn't be to hard. |
No worries, as long as this isn't released, it shouldn't be a problem. |
🎉 This PR is included in version 21.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
This introduces the
mapInteractions
config to theDefaultApplicationClientConfig
. It allows to configure which interactions should be added to the ol map of the gis-client.Corresponding handling needs to be added to the shogun-gis-client to actually make this work.
Related issues or pull requests
Pull request type
Do you introduce a breaking change?
Checklist
Apache Licence Version 2.0.
mvn test
locally).