Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HttpProxy): use override instead of bean creation for HttpSecurity #919

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Sep 11, 2024

Description

In order to make customHttpConfiguration overwriteable in subproject (as already used in InterceptorWebSecurityConfig), filterChain bean creation has to be removed in shogun-proxy

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@ahennr ahennr merged commit aa253ce into main Sep 11, 2024
4 checks passed
@ahennr ahennr deleted the http-proxy-fix branch September 11, 2024 12:03
Copy link
Contributor

🎉 This PR is included in version 20.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants