Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct mail dependencies #891

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: use correct mail dependencies #891

merged 1 commit into from
Jul 3, 2024

Conversation

buehner
Copy link
Member

@buehner buehner commented Jul 1, 2024

Description

This is a bugfix for the mail dependencies in succession of the spring 6 migration (sun vs jakarta packages).

Explanation:

The used parent pom spring-boot-dependencies (via spring-boot-starter-parent) declares a property jakarta-mail.version for the underlying jakarta.mail:jakarta.mail-api dependency. Within this project, this property has been "overwritten" and (mis-)used for the com.sun.mail:jakarta.mail dependency instead.

When using the mail functionality based on spring (JavaMailSender) this misconfiguration leads to an exception (could not find class...). The change of this PR fixes the issue.

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@KaiVolland
Copy link
Member

Do the two dependencies have to co-exists or can one of them be removed/replaced by the other one? Looks a bit confusing to me.

@buehner
Copy link
Member Author

buehner commented Jul 1, 2024

Yes. They have to co-exist. Mailing will not work otherwise.

Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@buehner buehner merged commit 2d0f3cd into main Jul 3, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Jul 3, 2024

🎉 This issue has been resolved in version 20.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants