Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: sonarqube-scan does not run when merging from dependabot #889

Merged
merged 2 commits into from
Jun 28, 2024
Merged

ci: sonarqube-scan does not run when merging from dependabot #889

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2046213
ci: sonarqube-scan does not run when merging from dependabot
FritzHoing Jun 28, 2024
0835862
Apply suggestions from code review
FritzHoing Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
run: mvn clean verify sonar:sonar --batch-mode -Dsonar.projectKey=SHOGun -Dsonar.login="${{ secrets.SONARQUBE_TOKEN }}" -Preporting

- name: Refresh SonarQube
if: steps.semantic.outputs.new_release_published == 'true'
if: ${{ github.actor != 'dependabot[bot]' && steps.semantic.outputs.new_release_published == 'true'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think }} is missing here

or ${{ isn't needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are absolutely right thank you!

FritzHoing marked this conversation as resolved.
Show resolved Hide resolved
run: mvn compile sonar:sonar --batch-mode -Dsonar.projectKey=SHOGun -Dsonar.host.url=${{ secrets.SONARQUBE_HOST }} -Dsonar.login="${{ secrets.SONARQUBE_TOKEN }}"

- name: Save cache
Expand Down
Loading