Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the BackgroundLayerChooser #510

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Disable the BackgroundLayerChooser #510

merged 1 commit into from
Nov 28, 2022

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Nov 28, 2022

This suggest to disable the BackgroundLayerChooser as it seems to be broken right now (see #485) and:

  • There is no way to define the required property isBackgroundLayer in shogun nor the shogun-admin.
  • There seems to be a conflict by setting it to a layer that is also visible in the tree (the layer must be visible in the tree to be catched up by the chooser).
  • There seems to be a request loop once a layer is activated in it.

Please review @terrestris/devs.

@dnlkoch
Copy link
Member Author

dnlkoch commented Nov 28, 2022

Thanks for the review!

@dnlkoch dnlkoch merged commit 76f4272 into main Nov 28, 2022
@dnlkoch dnlkoch deleted the disable-background-layer-switcher branch November 28, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FritzHoing FritzHoing FritzHoing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnlkoch @FritzHoing