test: change sonarqube configuration to cause job to fail when quality gate fails #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uality gate fails
|
dnlkoch
reviewed
May 13, 2024
There was a problem hiding this comment.
Not entirely sure if I understand it correctly, but this might have unexpected results:
- During the pull request pipeline no sonarqube check is performed.
- After being merged, the check is being performed on the
mainbranch. - If the check would fail, no build of the
mainwould happen. - In this case no image would be created and the
gh-pageswouldn't be updated.
This seems quite confusing to me since I would expect a succeeding main branch pipeline after merging a succeeding pull request pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the sonar.qualitygate.wait=true parameter which forces the sonarqube step to poll the SonarQube instance until the quality gate status is available.
It causes the sonarqube analysis step to fail any time the quality gate fails. The order in on-push-main workflow is changed to ensure sonarqube scan is carried out before each build. This means, build is not run if quality gate fails.
Also increases the pipeline duration!