Add a 'recompile' button #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
requested changes
Apr 9, 2024
There was a problem hiding this comment.
The preview shouldn't open new preview windows and should never change the active preview window.
Here I have a preview window for hi.d2, which imports yo.d2, but every time I hit recompile, it opens up the preview window for yo.d2 and switches that to the active.
Kapture.2024-04-09.at.14.38.46.mp4
Fixes terrastruct#133 This was fun. Tasks *really* want to be asynchronous, but I needed them to be synchronous.
…2-vscode into BarryNolte/issue133
alixander
requested changes
May 12, 2024
There was a problem hiding this comment.
got an error trying to build, i think some incompatibility in package.json
▶ osascript -e 'quit app "Visual Studio Code"'; yarn dev && code ~/dev/d2-demo
yarn run v1.22.21
warning [email protected]: The engine "vscode" appears to be invalid.
$ code --uninstall-extension terrastruct.d2; yarn gen && yarn pkg && code --install-extension d2.vsix
Extension 'terrastruct.d2' is not installed.
Make sure you use the full extension ID, including the publisher, e.g.: ms-dotnettools.csharp
warning [email protected]: The engine "vscode" appears to be invalid.
$ yq -o=json . syntaxes/d2.tmLanguage.yaml > syntaxes/d2.tmLanguage.json
warning [email protected]: The engine "vscode" appears to be invalid.
$ vsce package --out d2.vsix
(node:13800) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
ERROR @types/vscode ^1.89.0 greater than engines.vscode ^1.73.0. Consider upgrade engines.vscode or use an older @types/vscode version
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
|
Had to update the vscode module in two places, error only happens on package, not build |
alixander
requested changes
May 17, 2024
alixander
requested changes
May 18, 2024
|
I'm not able to reproduce this. |
|
Hmm can you screen record with it working? |
Untitled.video.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
Also fixes type bug in refreshTimer.ts (newer versions of node/lint warn)