Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first korean translation #177

Closed
wants to merge 0 commits into from
Closed

Conversation

Baejw0111
Copy link
Contributor

  • translation install.md to korean

I would like to translate the d2 docs site into Korean.

Copy link
Contributor

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baejw0111 thanks so much for putting the time and effort to do this.

I've made a PR to set translations up: https://github.com/terrastruct/d2-docs/pull/178/files

Can you rebase master and then move your file to the appropriate location? In this case it would be i18n/ko/docusaurus-plugin-content-docs/current/tour/install.md

Also can you sign your commit please? We have it set up as an org-wide setting: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@Baejw0111
Copy link
Contributor Author

Baejw0111 commented Aug 3, 2023

I applied all your requests. By the way, thank you very much for accepting my offer! I hope that the developers around me will use this good language a lot through this D2 docs translation work.

Copy link
Contributor

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like some commits are verified and some not, and it also looks like you might've merged the PR commits instead of master. Would you mind cleaning the history up please (such that the changes already in master don't show up in "Files changed")

Screen Shot 2023-08-03 at 12 39 16 PM

thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants