Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving HexBlock.getFlowArea #1995

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Improving HexBlock.getFlowArea #1995

wants to merge 3 commits into from

Conversation

john-science
Copy link
Member

What is the change?

Improved HexBlock.getFlowArea().

Why is the change being made?

The method HexBlock.getFlowArea() previously only accounted for regular coolant and not the inter-duct coolant.

close #1988

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the enhancement New feature or request label Oct 31, 2024
@john-science john-science marked this pull request as draft October 31, 2024 21:18
@john-science
Copy link
Member Author

NOTE: This PR works, and has been tested downstream. Everything looks good.

For reasons passing explanation, we are currently holding off on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clstocking clstocking Awaiting requested review from clstocking

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve HexBlock.getFlowArea() calculation
1 participant
@john-science