Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pin-related functionality #1990

Merged
merged 46 commits into from
Nov 22, 2024

Conversation

albeanth
Copy link
Member

@albeanth albeanth commented Oct 30, 2024

What is the change?

These changes are to support upgrades in pin-related functionality. The changes in this PR can be lumped into the following buckets:

  1. History Tracker: "detail assemblies" are now fuel and control assemblies. I also added some type hints to this module to help understand what was getting passed around.
  2. Removing blocks.py::Block::breakFuelComponentsIntoIndividuals. This is removed because it is a very memory expensive way of storing pin level characteristics. Storing data as numpy arrays is much more manageable.
  3. Move getPuMoles from blocks.py up to composites.py
  4. Populate molesHmBOL and puFrac on components during completeInitialLoading.
  5. Add a method getPinMgFluxes to retrieve the pin-wise multigroup fluxes from a Block.

Why is the change being made?

To support downstream pin-related functionality upgrades.

close #791


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@albeanth albeanth marked this pull request as draft October 30, 2024 22:27
@albeanth
Copy link
Member Author

@zachmprince a heads up

@john-science john-science added the feature request Smaller user request label Oct 30, 2024
@john-science
Copy link
Member

@albeanth Does this PR require any changes to the ARMI docs?

@albeanth
Copy link
Member Author

As of right now? No, not that I'm aware of.

doc/release/0.4.rst Outdated Show resolved Hide resolved
doc/release/0.4.rst Outdated Show resolved Hide resolved
doc/release/0.4.rst Outdated Show resolved Hide resolved
Co-authored-by: John Stilley <[email protected]>
@john-science
Copy link
Member

@zachmprince @albeanth I have bumped ARMI 0.5.0 (release coming soon).

This means that your release notes need to be moved from 0.4.1 in the file doc/release/0.4.rst to 0.5.0 in the file doc/release/0.5.rst.

Sorry to bother. I would have done this for you, but your PR is coming from a forked repo so I can't.

@albeanth
Copy link
Member Author

Sorry to bother. I would have done this for you, but your PR is coming from a forked repo so I can't.

All good. Already managed!

Copy link
Contributor

@drewj-tp drewj-tp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good. Minor function name change that is non-blocking

armi/reactor/parameters/parameterDefinitions.py Outdated Show resolved Hide resolved
armi/reactor/components/componentParameters.py Outdated Show resolved Hide resolved
armi/reactor/components/componentParameters.py Outdated Show resolved Hide resolved
armi/reactor/components/componentParameters.py Outdated Show resolved Hide resolved
@opotowsky opotowsky merged commit 01a5adf into terrapower:main Nov 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axialExpansionChanger and breakFuelComponentsIntoIndividuals() are not compatible
7 participants