-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating pin-related functionality #1990
Conversation
This reverts commit 76e36f3.
…u frac comp params
@zachmprince a heads up |
@albeanth Does this PR require any changes to the ARMI docs? |
As of right now? No, not that I'm aware of. |
Co-authored-by: John Stilley <[email protected]>
Co-authored-by: John Stilley <[email protected]>
@zachmprince @albeanth I have bumped ARMI This means that your release notes need to be moved from Sorry to bother. I would have done this for you, but your PR is coming from a forked repo so I can't. |
All good. Already managed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good. Minor function name change that is non-blocking
Co-authored-by: Drew Johnson <[email protected]>
What is the change?
These changes are to support upgrades in pin-related functionality. The changes in this PR can be lumped into the following buckets:
blocks.py::Block::breakFuelComponentsIntoIndividuals
. This is removed because it is a very memory expensive way of storing pin level characteristics. Storing data as numpy arrays is much more manageable.getPuMoles
from blocks.py up to composites.pymolesHmBOL
andpuFrac
on components duringcompleteInitialLoading
.getPinMgFluxes
to retrieve the pin-wise multigroup fluxes from aBlock
.Why is the change being made?
To support downstream pin-related functionality upgrades.
close #791
Checklist
This PR has only one purpose or idea.Sorry 😞doc
folder.pyproject.toml
.