Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving anl-afci-177 test files to their own directory #1957

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

john-science
Copy link
Member

What is the change?

Moved the anl-afci-177 data files to their own directory.

Why is the change being made?

Progress towards: #1867

The armi/tests/ directory has data files for 6 different reactors all just dumped into the same directory. This is part of on-going work to re-organize that directory to one sub-dir for each reactor.

This change will not affect downstream repos as I can find now downstream repo that uses the anl-afci-177 reactor or the TUTORIAL_DIR variable.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Oct 16, 2024
@john-science john-science changed the title Organize test dir Moving anl-afci-177 test files to their own directory Oct 16, 2024
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@john-science john-science merged commit 8b5163a into main Oct 17, 2024
19 checks passed
@john-science john-science deleted the organize_test_dir branch October 17, 2024 16:47
drewj-tp added a commit that referenced this pull request Oct 21, 2024
* origin/main:
  Updating cluster settings (#1958)
  Reducing warnings while building the docs (#1959)
  Moving anl-afci-177 test files to their own directory (#1957)
drewj-tp added a commit that referenced this pull request Oct 23, 2024
…xial-linkage

* origin/main:
  Loading some ARMI DBs without the App that created them (#1917)
  Revert "Revert "Updating cluster settings (#1958)" (#1965)" (#1969)
  Allowing users to define flag names with digits (#1966)
  Revert "Updating cluster settings (#1958)" (#1965)
  Updating cluster settings (#1958)
  Reducing warnings while building the docs (#1959)
  Moving anl-afci-177 test files to their own directory (#1957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants