Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strawman fix for the custom isotopics for testing. #1822

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakehader
Copy link
Member

What is the change?

Why is the change being made?


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science
Copy link
Member

@jakehader Just a reminder of the ARMI PR policy:

Don't open until it is ready
----------------------------
.. important ::
Wait until your PR is complete to open it.

We are all extremely busy, and if a PR gets opened before it is ready I will get an email:

  • every single time you commit, and the CI passes
  • for each and every time a single CI job fails

I love the help, and the interesting in fixing the feature. But in the future, please wait until the feature is ready for final review before opening a PR.

Comment on lines +304 to +311
print(comp.density())
print(f)
print(comp.inputTemperatureInC)
print(comp.temperatureInC)
scaledDensity = comp.density() / f
densityRatio = density / scaledDensity
comp.changeNDensByFactor(densityRatio)
print(comp.density())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to remove print statements.

@jakehader
Copy link
Member Author

@jakehader Just a reminder of the ARMI PR policy:

Don't open until it is ready
----------------------------
.. important ::
Wait until your PR is complete to open it.

We are all extremely busy, and if a PR gets opened before it is ready I will get an email:

  • every single time you commit, and the CI passes
  • for each and every time a single CI job fails

I love the help, and the interesting in fixing the feature. But in the future, please wait until the feature is ready for final review before opening a PR.

Thanks for the reminder @john-science - I put the PR here but forgot to make it a draft. This was just intended to provide some ideas for how to resolve the ticket and to put something out there to be stress tested by @keckler and others.

There are failing unit tests because I changed the construct arguments so that needs to be resolved still (probably a poor design to require case settings to build a component). Also, we will need to add more unit tests around custom Isotopics (same comment on the ticket).

@keckler
Copy link
Member

keckler commented Aug 15, 2024

I ran some tests on my FFTF model to see if this branch works. A couple points:

  1. The keff in my model increased by nearly 5000 pcm to a value that is very incorrect.
  2. The predicted isothermal temperature reactivity coefficient looks correct.
  3. The fuel density when the model is initialized to Thot is way too high (~10%).
  4. The change in density between different Thot values appears to be roughly correct, and the number of atoms is being correctly conserved.

So it seems like this change is half working. Somehow the initialized model is getting the densities very incorrect, though.

@jakehader
Copy link
Member Author

Was this fixed elsewhere @keckler?

@keckler
Copy link
Member

keckler commented Oct 30, 2024

Nope, still broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of custom isotopics with thermal expansion turned on does not correctly preserve mass
3 participants