Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize the armi/tests/ directory #1867

Open
2 of 6 tasks
john-science opened this issue Sep 11, 2024 · 2 comments
Open
2 of 6 tasks

Organize the armi/tests/ directory #1867

john-science opened this issue Sep 11, 2024 · 2 comments
Assignees
Labels
cleanup Code/comment cleanup: Low Priority testing Related to tests

Comments

@john-science
Copy link
Member

john-science commented Sep 11, 2024

The armi/tests/ directory has a bunch of unorganized data files. I would like these to be organized.

For instance, there are three YAML files to define the ZPPR benchmark reactor, those could go in their own directory!

Listed here are the data files, and where I would like them to go (with some notes about downstream repos that will need to be touched):

├── armi/tests/
└── anl-afci-177/
    ├── anl-afci-177-blueprints.yaml
    ├── anl-afci-177-fuelManagement.py
    ├── anl-afci-177.yaml
    ├── anl-afci-177-coreMap.yaml
└── c5g7/
    ├── c5g7-blueprints.yaml
    ├── c5g7-settings.yaml
└── resources/
    ├── armiRun-SHUFFLES.txt
    ├── COMPXS.ascii
    ├── geom.xml
    ├── geom1Assem.xml
    ├── ISOAA  (easy, because of the ISOAA_PATH variable)
└── sodiumHexReactor/  (downstream: cluster, deplection, neutronics, rxcoeffs)
    ├── armiRun.yaml
    ├── refSmallReactorShuffleLogic.py
    ├── refSmallReactor.yaml
    ├── refSmallSfpGrid.yaml
    ├── refSmallCoreGrid.yaml
    ├── refSmallReactorBase.yaml
└── thetarz/  (downstream: neutronics)
    ├── ThRZGeom.xml
    ├── ThRZloading.yaml
    ├── ThRZSettings.yaml
    ├── trz_geom.xml
└── zppr/  (downstream: mcnp, neutronics)
    ├── 1DslabXSByCompTest.yaml
    ├── zpprTest.yaml
    ├── zpprTestGeom.xml

I expect this to be done in stages, because it will require cleanup downstream:

  • anl-afci-177/
  • c5g7/
  • resources/
  • sodiumHexReactor/
  • thetarz/
  • zppr/
@john-science john-science added cleanup Code/comment cleanup: Low Priority testing Related to tests labels Sep 11, 2024
@john-science john-science self-assigned this Sep 11, 2024
@john-science
Copy link
Member Author

Also, while we're at it, when not add a comment at the top of these files explaining what is in them, and what they are for.

Let's go nuts!

@john-science
Copy link
Member Author

john-science commented Sep 11, 2024

Other strange or messy things in ARMI I should investigate:

The book keeping test file _constants.py seems silly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority testing Related to tests
Projects
None yet
Development

No branches or pull requests

1 participant