-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration for clang-format #406
Configuration for clang-format #406
Conversation
caaa5e6
to
fdec231
Compare
fdec231
to
f7f74b5
Compare
I don't know what the state of this PR is, but I would greatly appreciate having a clang-format file, because Visual Studio can detect these, which would make it easier to edit code files without having to fight my own default formatting options or try to reverse-engineer what the project is doing. |
I think my last push should have unbroken the build. The only issue at this point is that this commit needs to be done in coordination with the other outstanding branches so that we don't lose all our outstanding PRs when we do this. (I do not want to deal with the merge conflicts.) Good news is I figured out how to do this with |
Given that I still have three or so more planned PRs, I would like to get this in sooner rather than later. Can you detail the manual steps needed to make this happen so I can either split the work with you or do it myself? |
I'll try to get to this today, and if I can't finish I'll follow up with instructions on how to do it. Making for myself the list of branches that need to be kept up to date:
If anyone else has outstanding branches that touch C/C++ files, let me know now or you will have substantial merge conflicts in the near future. |
f7f74b5
to
476ec3a
Compare
476ec3a
to
73c9442
Compare
I took a look at this, looks fine for me, can rebase after this is merged |
73c9442
to
7009c36
Compare
I did it over again because apparently clang-format is not compatible between releases. I am declaring that clang-format 9.0 is the official version for Terra, at least for the time being. There will be a subsequent update that will enforce that. |
Ok, merged. |
I updated all the original branches except for aiverson:master, which I'm guessing really wants to be a separate branch anyway. @aiverson you may need to do to this yourself. Other than that we should be good. |
Add clang-format configuration and run it. Contains only cosmetic changes (aside from
.clang-format
andformat.sh
).