Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added fix to use basename of kms config #786

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

manojburi-google2
Copy link
Contributor

@manojburi-google2 manojburi-google2 commented Dec 19, 2024

Changes are inline with https://github.com/GoogleCloudPlatform/magic-modules/pull/12418/files#

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@manojburi-google2 manojburi-google2 requested review from a team as code owners December 19, 2024 14:13
@glasnt glasnt changed the title Added fix to use basename of kms config fix: added fix to use basename of kms config Dec 19, 2024
@glasnt
Copy link
Contributor

glasnt commented Dec 19, 2024

/gcbrun

@glasnt glasnt changed the title fix: added fix to use basename of kms config Added fix to use basename of kms config Dec 19, 2024
@glasnt glasnt changed the title Added fix to use basename of kms config fix: added fix to use basename of kms config Dec 19, 2024
@glasnt glasnt merged commit 44c5550 into terraform-google-modules:main Dec 19, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants